Replace folly::make_unique with std::make_unique#26730
Closed
JoeLoser wants to merge 1 commit into
Closed
Conversation
Problem: - `folly::make_unique` is a backport library implementation of `std::make_unique` for those using compilers without C++14 support. Solution: - Replace calls of `folly::make_unique` with `std::make_unique`.
facebook-github-bot
added
the
CLA Signed
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@JoshuaGross has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @JoeLoser in ba18ee9. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
Thanks for the PR @JoeLoser! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is a mixed usage of
folly::make_uniqueandstd::make_unique. Soon,folly::make_uniquemay be removed (see this PR). Sincereact-nativeonly supports C++14-compilers and later, switch to always usingstd::make_unique.Changelog
[Internal] [Removed] - Replace folly::make_unique with std::make_unique
Test Plan
Running the existing test suite. No change in behavior is expected.