Skip to content

Update README.md#26879

Closed
Priyanshu2001 wants to merge 1 commit into
facebook:masterfrom
Priyanshu2001:patch-1
Closed

Update README.md#26879
Priyanshu2001 wants to merge 1 commit into
facebook:masterfrom
Priyanshu2001:patch-1

Conversation

@Priyanshu2001
Copy link
Copy Markdown
Contributor

Omitted 'own'.. from 2nd para 3rd line.
Added comma in 3rd line after 'developing tools' under the "Upgrading" topic.
bugfixes>> Bug fixes in 7th line under topic "How to contribute".

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

Omitted 'own'.. from 2nd para 3rd line.
Added comma in 3rd line after 'developing tools' under the "Upgrading" topic.
bugfixes>> Bug fixes in 7th line under topic "How to contribute".
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi Priyanshu2001! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added the No CLA Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2019
Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR with small improvements.

@cpojer
Copy link
Copy Markdown
Contributor

cpojer commented Oct 28, 2019

@Priyanshu2001 could you sign the CLA so we can merge this change? See code.facebook.com/cla – it only takes a minute :)

@cpojer
Copy link
Copy Markdown
Contributor

cpojer commented Oct 30, 2019

Unfortunately can't merge this without a CLA :( Let me know if you sign it and I'll reopen and merge this PR.

@cpojer cpojer closed this Oct 30, 2019
@Priyanshu2001
Copy link
Copy Markdown
Contributor Author

Priyanshu2001 commented Oct 30, 2019 via email

@Priyanshu2001
Copy link
Copy Markdown
Contributor Author

Priyanshu2001 commented Oct 30, 2019 via email

@cpojer cpojer reopened this Oct 31, 2019
@cpojer
Copy link
Copy Markdown
Contributor

cpojer commented Oct 31, 2019

Hello again @Priyanshu2001! Could you check again whether you filled it out correctly? Please go to https://code.facebook.com/cla and make sure you username is correct when you sign it :)

@Priyanshu2001
Copy link
Copy Markdown
Contributor Author

Priyanshu2001 commented Nov 1, 2019 via email

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2019
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-native-bot react-native-bot removed the No CLA Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2019
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Priyanshu2001 in 5a4d68f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants