Update README.md#26879
Conversation
Omitted 'own'.. from 2nd para 3rd line. Added comma in 3rd line after 'developing tools' under the "Upgrading" topic. bugfixes>> Bug fixes in 7th line under topic "How to contribute".
|
Hi Priyanshu2001! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
cpojer
left a comment
There was a problem hiding this comment.
Thanks for the PR with small improvements.
|
@Priyanshu2001 could you sign the CLA so we can merge this change? See code.facebook.com/cla – it only takes a minute :) |
|
Unfortunately can't merge this without a CLA :( Let me know if you sign it and I'll reopen and merge this PR. |
|
I have signed it
…On Wed, Oct 30, 2019, 21:36 Christoph Nakazawa ***@***.***> wrote:
Unfortunately can't merge this without a CLA :( Let me know if you sign it
and I'll reopen and merge this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26879?email_source=notifications&email_token=ANMCBBJKRMEEB4L52LU6N3LQRGWJ7A5CNFSM4JBJGUWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECUXOAI#issuecomment-547976961>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANMCBBMHKCGVX2XPTDTQQTLQRGWJ7ANCNFSM4JBJGUWA>
.
|
|
I have signed it ... But if there is an issue please kindly send me cla url
again..
Thanks!
…On Wed, Oct 30, 2019, 22:03 priyanshu bansal ***@***.***> wrote:
I have signed it
On Wed, Oct 30, 2019, 21:36 Christoph Nakazawa ***@***.***>
wrote:
> Unfortunately can't merge this without a CLA :( Let me know if you sign
> it and I'll reopen and merge this PR.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#26879?email_source=notifications&email_token=ANMCBBJKRMEEB4L52LU6N3LQRGWJ7A5CNFSM4JBJGUWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECUXOAI#issuecomment-547976961>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANMCBBMHKCGVX2XPTDTQQTLQRGWJ7ANCNFSM4JBJGUWA>
> .
>
|
|
Hello again @Priyanshu2001! Could you check again whether you filled it out correctly? Please go to https://code.facebook.com/cla and make sure you username is correct when you sign it :) |
|
I have done it!!
…On Thu, Oct 31, 2019, 16:51 Christoph Nakazawa ***@***.***> wrote:
Hello again @Priyanshu2001 <https://github.com/Priyanshu2001>! Could you
check again whether you filled it out correctly? Please go to
https://code.facebook.com/cla and make sure you username is correct when
you sign it :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26879?email_source=notifications&email_token=ANMCBBKXQG4S6RYZY6TZ4FTQRK5TPA5CNFSM4JBJGUWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECXL46A#issuecomment-548322936>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANMCBBPFQE2XYZG5SLN66B3QRK5TPANCNFSM4JBJGUWA>
.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @Priyanshu2001 in 5a4d68f. When will my fix make it into a release? | Upcoming Releases |
Omitted 'own'.. from 2nd para 3rd line.
Added comma in 3rd line after 'developing tools' under the "Upgrading" topic.
bugfixes>> Bug fixes in 7th line under topic "How to contribute".
Summary
Changelog
[CATEGORY] [TYPE] - Message
Test Plan