[flipper] Fix RNTester integration with Flipper#27482
Closed
passy wants to merge 2 commits into
Closed
Conversation
Summary: There was a reflective call to a non-existent class. It did, however, exist in the template, so I copied it over from there and updated the references accordingly. Test Plan: Built it and ran it. Works again with the latest Flipper desktop app.
facebook-github-bot
added
CLA Signed
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mdvacca
approved these changes
Dec 12, 2019
|
|
||
| public class ReactNativeFlipper { | ||
| public static void initializeFlipper(Context context, ReactInstanceManager reactInstanceManager) { | ||
| if (FlipperUtils.shouldEnableFlipper(context)) { |
Contributor
There was a problem hiding this comment.
Is it documented how to enable flipper? By default it will not work in debug mode, right?
Member
Author
There was a problem hiding this comment.
It should work by default in debug builds. :) This is just an additional check to ensure that this is a) an IS_INTERNAL_BUILD b) not an end-to-end test (but that's FB-specific) and c) is on the main process as apps with multiple processes may not map native libraries into their address space.
Collaborator
|
This pull request was successfully merged by @passy in 68bf0e3. When will my fix make it into a release? | Upcoming Releases |
30 tasks
rickhanlonii
pushed a commit
that referenced
this pull request
Jan 29, 2020
Summary: There was a reflective call to a non-existent class. It did, however, exist in the template, so I copied it over from there and updated the references accordingly. Pull Request resolved: #27482 Test Plan: Built it and ran it. Works again with the latest Flipper desktop app.  Reviewed By: rickhanlonii Differential Revision: D18933530 Pulled By: passy fbshipit-source-id: 4515d7baaad9a9fff9a4b66e1cbf8a75889e6e45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There was a reflective call to a non-existent class. It did, however,
exist in the template, so I copied it over from there and updated
the references accordingly.
Test Plan:
Built it and ran it. Works again with the latest Flipper desktop app.