Add AnimatedInterpolation as possible type for toValue#27558
Conversation
|
Hi nabati! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Any idea why the tests fail? At first glance it doesn't look related to the changes, as they are happening with the native build and I've only changed the flow-types. @GummyGod |
|
To be honest I am not sure, but, I think it might be a problem with the Polyfills. Someone from the core team might be helpful here. |
|
If you look at all the recent pull requests they all fail the test_ios_framworks test :( So probably not something you've done. |
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
Thank you for adding the type.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @nabati in 26e8870. When will my fix make it into a release? | Upcoming Releases |
Summary: AnimatedInterpolation should be a valid type to pass to `toValue` according to the documentation. https://facebook.github.io/react-native/docs/animations#tracking-dynamic-values ## Changelog [General] [Fixed] - Add AnimationInterpolation as possible type for toValue Pull Request resolved: facebook#27558 Test Plan: `yarn flow` works without errors. Differential Revision: D19296804 Pulled By: cpojer fbshipit-source-id: 7f09c762308c40f1eede5834fadf1837114aa397
6 participants
Summary
AnimatedInterpolation should be a valid type to pass to
toValueaccording to the documentation.https://facebook.github.io/react-native/docs/animations#tracking-dynamic-values
Changelog
[General] [Fixed] - Add AnimationInterpolation as possible type for toValue
Test Plan
yarn flowworks without errors.