Adjust HelloWorld-tvOSTests/Info.plist CFBundleIdentifier to use PR ODUCT_BUNDLE_IDENTIFIER#27601
Closed
MoOx wants to merge 1 commit into
Closed
Adjust HelloWorld-tvOSTests/Info.plist CFBundleIdentifier to use PR ODUCT_BUNDLE_IDENTIFIER#27601MoOx wants to merge 1 commit into
CFBundleIdentifier to use PR ODUCT_BUNDLE_IDENTIFIER#27601MoOx wants to merge 1 commit into
Conversation
…ODUCT_BUNDLE_IDENTIFIER ## Summary In other part of the hello world, this replacement has been made already. The only place left this way (which make sense) is in `HelloWorld.xcodeproj/project.pbxproj`. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. See https://github.com/facebook/react-native/wiki/Changelog for an example. --> [General] [Fixed] - Adjust HelloWorld-tvOSTests/Info.plist `CFBundleIdentifier` to use PRODUCT_BUNDLE_IDENTIFIER ## Test Plan I made this change locally on a project. No big deal as this is a test piece, not going to go on any kind of real world environment.
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: tvOS
facebook-github-bot
approved these changes
Dec 27, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @MoOx in 98ebc1e. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
… ODUCT_BUNDLE_IDENTIFIER (facebook#27601) Summary: In other part of the hello world, this replacement has been made already. The only place left this way (which make sense) is in `HelloWorld.xcodeproj/project.pbxproj`. ## Changelog [General] [Fixed] - Adjust HelloWorld-tvOSTests/Info.plist `CFBundleIdentifier` to use PRODUCT_BUNDLE_IDENTIFIER Pull Request resolved: facebook#27601 Test Plan: I made this change locally on a project. No big deal as this is a test piece, not going to go on any kind of real world environment. Differential Revision: D19235760 Pulled By: cpojer fbshipit-source-id: 95b9936acc1eaddf3f5a86c733f46c5a80ac6423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In other part of the hello world, this replacement has been made already. The only place left this way (which make sense) is in
HelloWorld.xcodeproj/project.pbxproj.Changelog
[General] [Fixed] - Adjust HelloWorld-tvOSTests/Info.plist
CFBundleIdentifierto use PRODUCT_BUNDLE_IDENTIFIERTest Plan
I made this change locally on a project. No big deal as this is a test piece, not going to go on any kind of real world environment.