Bump detox simulator version to work with latest xcode#27733
Closed
rickhanlonii wants to merge 1 commit into
Closed
Bump detox simulator version to work with latest xcode#27733rickhanlonii wants to merge 1 commit into
rickhanlonii wants to merge 1 commit into
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Collaborator
|
This pull request was successfully merged by @rickhanlonii in 5cd0c8a. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: The latest xcode version removed iPhone 6s, so we need to bump to the latest simulator listed that has 3d touch. ## Changelog [General] [Fix] - Bump e2e simulator version Pull Request resolved: facebook#27733 Test Plan: - `yarn build-ios-e2e && yarn test-ios-e2e ` Reviewed By: hramos, sammy-SC Differential Revision: D19345576 Pulled By: rickhanlonii fbshipit-source-id: 428cb83ccb899409e972551f18df580174adee91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The latest xcode version removed iPhone 6s, so we need to bump to the latest simulator listed that has 3d touch.
Changelog
[General] [Fixed] - Bump e2e simulator version
Test Plan
yarn build-ios-e2e && yarn test-ios-e2e