Skip to content

Bump detox simulator version to work with latest xcode#27733

Closed
rickhanlonii wants to merge 1 commit into
facebook:masterfrom
rickhanlonii:rh-fix-detox
Closed

Bump detox simulator version to work with latest xcode#27733
rickhanlonii wants to merge 1 commit into
facebook:masterfrom
rickhanlonii:rh-fix-detox

Conversation

@rickhanlonii
Copy link
Copy Markdown
Member

@rickhanlonii rickhanlonii commented Jan 10, 2020

Summary

The latest xcode version removed iPhone 6s, so we need to bump to the latest simulator listed that has 3d touch.

Changelog

[General] [Fixed] - Bump e2e simulator version

Test Plan

  • yarn build-ios-e2e && yarn test-ios-e2e

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team labels Jan 10, 2020
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@pull-bot
Copy link
Copy Markdown

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 5083ccb

@rickhanlonii rickhanlonii changed the title Bump detox and simulator version to work with latest xcode Bump detox simulator version to work with latest xcode Jan 10, 2020
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @rickhanlonii in 5cd0c8a.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 13, 2020
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
Summary:
The latest xcode version removed iPhone 6s, so we need to bump to the latest simulator listed that has 3d touch.

## Changelog

[General] [Fix] - Bump e2e simulator version
Pull Request resolved: facebook#27733

Test Plan: - `yarn build-ios-e2e && yarn test-ios-e2e `

Reviewed By: hramos, sammy-SC

Differential Revision: D19345576

Pulled By: rickhanlonii

fbshipit-source-id: 428cb83ccb899409e972551f18df580174adee91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants