Skip to content

[CI] Skip testNotUTF8Convertible (correct path)#27767

Closed
hramos wants to merge 1 commit into
facebook:masterfrom
hramos:skip-ios-json-circleci
Closed

[CI] Skip testNotUTF8Convertible (correct path)#27767
hramos wants to merge 1 commit into
facebook:masterfrom
hramos:skip-ios-json-circleci

Conversation

@hramos
Copy link
Copy Markdown
Contributor

@hramos hramos commented Jan 15, 2020

Summary

Use correct path to testNotUTF8Convertible which is being skipped.

Changelog

[Internal] - Use correct path to testNotUTF8Convertible which is being skipped.

Test Plan

Circle CI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team labels Jan 15, 2020
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jan 15, 2020

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 4ff3b04

@hramos hramos changed the title Skip testNotUTF8Convertible (correct path) [CI] Skip testNotUTF8Convertible (correct path) Jan 15, 2020
facebook-github-bot
facebook-github-bot approved these changes Jan 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Jan 15, 2020

This pull request was successfully merged by @hramos in 8b735a2.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 15, 2020
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
@hramos @osdnk
Skip testNotUTF8Convertible (correct path) (facebook#27767)
7064afe 
Summary:
Use correct path to testNotUTF8Convertible which is being skipped.

## Changelog

[Internal] - Use correct path to testNotUTF8Convertible which is being skipped.
Pull Request resolved: facebook#27767

Test Plan: Circle CI

Differential Revision: D19404469

Pulled By: hramos

fbshipit-source-id: 70cf06c90dac74ac7963b9a35a543e11b21ba471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hramos @pull-bot @react-native-bot @facebook-github-bot