Skip to content

fix: resolve Require Cycle warning #27851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Naturalclar wants to merge 4 commits into from
Closed

fix: resolve Require Cycle warning #27851

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
146b296
fix: resolve Require Cycle warning
Naturalclar Jan 24, 2020
0a4ba9c
chore: apply lint
Naturalclar Jan 24, 2020
d09f8cf
chore: import ScrollView as type
Naturalclar Jan 27, 2020
e448c90
chore: change import typeof
Naturalclar Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Libraries/Components/ScrollResponder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ const ReactNative = require('../Renderer/shims/ReactNative');
const TextInputState = require('./TextInput/TextInputState');
const UIManager = require('../ReactNative/UIManager');
const Platform = require('../Utilities/Platform');
const ScrollView = require('./ScrollView/ScrollView');
import Commands from './ScrollView/ScrollViewCommands';

const invariant = require('invariant');
const performanceNow = require('fbjs/lib/performanceNow');

import type {PressEvent, ScrollEvent} from '../Types/CoreEventTypes';
import typeof ScrollView from './ScrollView/ScrollView';
import type {Props as ScrollViewProps} from './ScrollView/ScrollView';
import type {KeyboardEvent} from './Keyboard/Keyboard';
import type EmitterSubscription from '../vendor/emitter/EmitterSubscription';
Expand Down Expand Up @@ -468,7 +468,7 @@ const ScrollResponderMixin = {
({x, y, animated} = x || {});
}

const that: React.ElementRef<typeof ScrollView> = (this: any);
Comment thread
Naturalclar marked this conversation as resolved.
Comment thread
Naturalclar marked this conversation as resolved.
Comment thread
Naturalclar marked this conversation as resolved.
const that: React.ElementRef<ScrollView> = (this: any);
invariant(
that.getNativeScrollRef != null,
'Expected scrollTo to be called on a scrollViewRef. If this exception occurs it is likely a bug in React Native',
Expand All @@ -492,7 +492,7 @@ const ScrollResponderMixin = {
// Default to true
const animated = (options && options.animated) !== false;

Comment thread
Naturalclar marked this conversation as resolved.
Comment thread
Naturalclar marked this conversation as resolved.
Comment thread
Naturalclar marked this conversation as resolved.
const that: React.ElementRef<typeof ScrollView> = (this: any);
const that: React.ElementRef<ScrollView> = (this: any);
invariant(
that.getNativeScrollRef != null,
'Expected scrollToEnd to be called on a scrollViewRef. If this exception occurs it is likely a bug in React Native',
Expand Down Expand Up @@ -531,7 +531,7 @@ const ScrollResponderMixin = {
);
}

const that: React.ElementRef<typeof ScrollView> = this;
const that: React.ElementRef<ScrollView> = this;
invariant(
that.getNativeScrollRef != null,
'Expected zoomToRect to be called on a scrollViewRef. If this exception occurs it is likely a bug in React Native',
Expand All @@ -547,7 +547,7 @@ const ScrollResponderMixin = {
* Displays the scroll indicators momentarily.
Comment thread
Naturalclar marked this conversation as resolved.
Comment thread
Naturalclar marked this conversation as resolved.
Comment thread
Naturalclar marked this conversation as resolved.
*/
scrollResponderFlashScrollIndicators: function() {
const that: React.ElementRef<typeof ScrollView> = (this: any);
const that: React.ElementRef<ScrollView> = (this: any);
invariant(
that.getNativeScrollRef != null,
'Expected flashScrollIndicators to be called on a scrollViewRef. If this exception occurs it is likely a bug in React Native',
Expand Down