Skip to content

Add URLSearchParams and Headers to eslint globals#27853

Closed
sonnyp wants to merge 3 commits into
facebook:masterfrom
sonnyp:patch-1
Closed

Add URLSearchParams and Headers to eslint globals#27853
sonnyp wants to merge 3 commits into
facebook:masterfrom
sonnyp:patch-1

Conversation

@sonnyp
Copy link
Copy Markdown
Contributor

@sonnyp sonnyp commented Jan 24, 2020

Fix eslint complaining about URLSearchParams and Headers not being defined.

@sonnyp sonnyp requested a review from matt-oakes as a code owner January 24, 2020 12:31
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2020
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jan 24, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against c1a3144

@matt-oakes
Copy link
Copy Markdown
Contributor

Can you also bump the version number in the packages package.json so I can release it when this PR is merged?

@sonnyp sonnyp changed the title Add URLSearchParams to eslint globals Add URLSearchParams and Headers to eslint globals Jan 24, 2020
@sonnyp
Copy link
Copy Markdown
Contributor Author

sonnyp commented Jan 24, 2020

@matt-oakes done - also added Headers to eslint globals

Copy link
Copy Markdown
Contributor

@matt-oakes matt-oakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! This will need to be merged by someone with the correct permissions (cc @cpojer) and then I can release a new version onto NPM.

Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @sonnyp in 7a13a1a.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 27, 2020
@matt-oakes
Copy link
Copy Markdown
Contributor

Published to NPM as 0.0.7 👍

@sonnyp sonnyp deleted the patch-1 branch January 27, 2020 12:38
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
Summary:
Fix eslint complaining about `URLSearchParams` and `Headers` not being defined.
Pull Request resolved: facebook#27853

Differential Revision: D19577641

Pulled By: cpojer

fbshipit-source-id: 7019d1519523c7b99a201c6e0b78d0035c9b35a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants