Fabric: Fix various includes#27947
Closed
empyrical wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@sammy-SC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @empyrical in ca81037. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: This pull request fixes a few `#include`s in the Fabric source: * Changes `<Glog/logging.h>` to `<glog/logging.h>` in two files, which was an issue for case-sensitive file systems * In `ParagraphProps.cpp`, changes the include of `attributedstring/primitives.h` from a relative style to a more absolute style. ## Changelog [Internal] [Fixed] - Fabric: Fix various includes Pull Request resolved: facebook#27947 Test Plan: Fabric compiles perfectly, and the Fabric test suite passes. Reviewed By: shergin Differential Revision: D19788148 Pulled By: sammy-SC fbshipit-source-id: 30a297e8aea50c7c7fd5f48745edf04811a6bdbd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a few
#includes in the Fabric source:<Glog/logging.h>to<glog/logging.h>in two files, which was an issue for case-sensitive file systemsParagraphProps.cpp, changes the include ofattributedstring/primitives.hfrom a relative style to a more absolute style.Changelog
[Internal] [Fixed] - Fabric: Fix various includes
Test Plan
Fabric compiles perfectly, and the Fabric test suite passes.