Skip to content

chore: tweak missing RCTAnimation warning message#28139

Closed
radko93 wants to merge 1 commit into
facebook:masterfrom
radko93:patch-5
Closed

chore: tweak missing RCTAnimation warning message#28139
radko93 wants to merge 1 commit into
facebook:masterfrom
radko93:patch-5

Conversation

@radko93
Copy link
Copy Markdown
Contributor

@radko93 radko93 commented Feb 20, 2020

Summary

As we don't link modules manually anymore it's better to point the user in another direction when he faces this issue.

Changelog

[Internal] [Changed] - tweak missing RCTAnimation warning message

As we don't link modules manually it's better to point the user in another direction when he faces this issue,
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2020
@pull-bot
Copy link
Copy Markdown

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 1d745c5

@analysis-bot
Copy link
Copy Markdown

RNTester.app (iOS): 10657792 bytes

@analysis-bot
Copy link
Copy Markdown

RNTester (Android/hermes/arm64-v8a): 3289088 bytes
RNTester (Android/hermes/armeabi-v7a): 3129344 bytes
RNTester (Android/hermes/x86): 3459072 bytes
RNTester (Android/hermes/x86_64): 3424256 bytes
RNTester (Android/jsc/arm64-v8a): 4444160 bytes
RNTester (Android/jsc/armeabi-v7a): 4265984 bytes
RNTester (Android/jsc/x86): 4358144 bytes
RNTester (Android/jsc/x86_64): 4644864 bytes

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @radko93 in 1c5938e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 20, 2020
@radko93 radko93 deleted the patch-5 branch February 21, 2020 10:13
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
Summary:
As we don't link modules manually anymore it's better to point the user in another direction when they face this issue.

## Changelog

[Internal] [Changed] - tweak missing RCTAnimation warning message

Pull Request resolved: facebook#28139

Reviewed By: cpojer

Differential Revision: D20009264

Pulled By: hramos

fbshipit-source-id: 114cae4fe908186eab3d8d9e79c2016015406821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants