Image: remove unused ImageProps#28151
Closed
Naturalclar wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
|
RNTester (Android/hermes/arm64-v8a): 3291136 bytes |
|
RNTester.app (iOS): 10657792 bytes |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @Naturalclar in fbd09b1. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: I noticed that there was a `height` and `width` props in `Image` component, but those props are not being used in `RCTImageView`(ios) or `ReactImageView`(android). ## Changelog [GENERAL] [Removed] - Remove Unused ImageProp Pull Request resolved: facebook#28151 Test Plan: Start a new React Native Project, and use `Image` component with `width` and `height` props and verify that it does not display the image on both iOS and Android Reviewed By: shergin Differential Revision: D20197126 Pulled By: TheSavior fbshipit-source-id: 186119448826659d7c01c7c8a271157228169c30
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that there was a
heightandwidthprops inImagecomponent, but those props are not being used inRCTImageView(ios) orReactImageView(android).Changelog
[GENERAL] [Removed] - Remove Unused ImageProp
Test Plan
Start a new React Native Project, and use
Imagecomponent withwidthandheightprops and verify that it does not display the image on both iOS and Android