Skip to content

Add RNTester example for multi-line interleaved <View> and <Text>#28242

Closed
aleclarson wants to merge 1 commit intofacebook:masterfrom
aleclarson:test-1
Closed

Add RNTester example for multi-line interleaved <View> and <Text>#28242
aleclarson wants to merge 1 commit intofacebook:masterfrom
aleclarson:test-1

Conversation

@aleclarson
Copy link
Copy Markdown
Contributor

@aleclarson aleclarson commented Mar 5, 2020

Summary

Currently, using alignSelf: "baseline" on a <View> nested in a <Text> fails to position the view properly. Using alignItems: "baseline" on the parent <Text> doesn't work either.

/cc @shergin

Current Result

rn-baseline-nested-view

Expected Result

rn-baseline-nested-text

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2020
@pull-bot
Copy link
Copy Markdown

pull-bot commented Mar 5, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against c083dfa

@analysis-bot
Copy link
Copy Markdown

RNTester.app (iOS): 10731520 bytes

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by Alec Larson in 3743675.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants