Add RNTester example for multi-line interleaved <View> and <Text>#28242
Closed
aleclarson wants to merge 1 commit intofacebook:masterfrom
Closed
Add RNTester example for multi-line interleaved <View> and <Text>#28242aleclarson wants to merge 1 commit intofacebook:masterfrom
aleclarson wants to merge 1 commit intofacebook:masterfrom
Conversation
|
|
RNTester.app (iOS): 10731520 bytes |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by Alec Larson in 3743675. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, using
alignSelf: "baseline"on a<View>nested in a<Text>fails to position the view properly. UsingalignItems: "baseline"on the parent<Text>doesn't work either./cc @shergin
Current Result
Expected Result