Improve test manual e2e script #28382
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -24,98 +24,139 @@ info() { | |||||
| echo -e "$BLUE""$*""$ENDCOLOR" | ||||||
| } | ||||||
|
|
||||||
| kill_packagers() { | ||||||
| success "Killing any running packagers" | ||||||
| lsof -i :8081 | grep LISTEN | ||||||
| lsof -i :8081 | grep LISTEN | /usr/bin/awk '{print $2}' | xargs kill | ||||||
| } | ||||||
|
|
||||||
| REPO_ROOT=$(pwd) | ||||||
| CLI_PATH="$REPO_ROOT/cli.js" | ||||||
|
|
||||||
| PACKAGE_VERSION=$(cat package.json \ | ||||||
| | grep version \ | ||||||
| | head -1 \ | ||||||
| | awk -F: '{ print $2 }' \ | ||||||
| | sed 's/[",]//g' \ | ||||||
| | tr -d '[[:space:]]') | ||||||
|
|
||||||
| ANDROID_EMULATOR_NAME=${ANDROID_EMULATOR_NAME:-$(emulator -list-avds | awk '{print $1}')} | ||||||
|
|
||||||
| # Prepare | ||||||
| { | ||||||
| info "Preparing version $PACKAGE_VERSION" | ||||||
|
|
||||||
| # Do this as early as possible, so there's a bit of time for the emulator to launch before we interact with it | ||||||
| info "Launching Android emulator: $ANDROID_EMULATOR_NAME" | ||||||
| emulator -no-boot-anim -avd "$ANDROID_EMULATOR_NAME" & | ||||||
|
|
||||||
| yarn install | ||||||
|
|
||||||
| rm -rf android | ||||||
| ./gradlew :ReactAndroid:installArchives || error "Couldn't generate artifacts" | ||||||
|
|
||||||
| kill_packagers | ||||||
| } | ||||||
|
|
||||||
| # Test RNTester | ||||||
| { | ||||||
| info "Starting the packager in the background" | ||||||
| node "$CLI_PATH" start & | ||||||
|
|
||||||
| # Android | ||||||
| { | ||||||
| ./gradlew :RNTester:android:app:installJscDebug || error "Couldn't build RNTester Android" | ||||||
|
|
||||||
| info "Deleting previously installed Android RNTester app" | ||||||
| adb uninstall com.facebook.react.uiapp | ||||||
|
|
||||||
|
|
||||||
| info "Press any key to run RNTester in an already running Android emulator/device" | ||||||
| info "" | ||||||
| read -n 1 | ||||||
| adb shell am start -n com.facebook.react.uiapp/.RNTesterActivity | ||||||
| } | ||||||
|
|
||||||
| # iOS | ||||||
| pushd RNTester | ||||||
| { | ||||||
| info "Press any key to open the workspace in Xcode, then build and test manually." | ||||||
|
Contributor
There was a problem hiding this comment. not sure if it should live here or not, but I was wondering if it was useful to run |
||||||
| info "" | ||||||
| read -n 1 | ||||||
| success "Installing CocoaPods dependencies" | ||||||
| rm -rf Pods && pod install | ||||||
|
Contributor
There was a problem hiding this comment. ...and
Contributor
Author
There was a problem hiding this comment. Hmm, yeah that seems a bit much. What is your experience with this?
Contributor
There was a problem hiding this comment. tbh just that I am a bad person and I do tabula rasa on my projects when I need to ensure full clean 😂 and you know way better than me how Pods work so I'm fully ok with not including this command 👍 |
||||||
| open "RNTesterPods.xcworkspace" | ||||||
| } | ||||||
| popd | ||||||
|
|
||||||
| info "When done testing RNTester app on iOS and Android press any key to continue." | ||||||
| info "" | ||||||
| read -n 1 | ||||||
|
|
||||||
| kill_packagers | ||||||
| } | ||||||
|
|
||||||
| # Test new app from template | ||||||
| { | ||||||
| npm pack | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
(or is it a npm specific command?)
Contributor
Author
There was a problem hiding this comment. Not really, but it also doesn’t do anything with version resolving, so I’m less worried about it. I can take a look, though, and make the whole script uniform 👍 |
||||||
|
|
||||||
| PACKAGE=$(pwd)/react-native-$PACKAGE_VERSION.tgz | ||||||
| success "Package bundled ($PACKAGE)" | ||||||
|
|
||||||
| node scripts/set-rn-template-version.js "file:$PACKAGE" | ||||||
| success "React Native version changed in the template" | ||||||
|
|
||||||
| project_name="RNTestProject" | ||||||
| project_dirname="/tmp" | ||||||
| project_path="${project_dirname}/${project_name}" | ||||||
|
|
||||||
| pushd "$project_dirname" | ||||||
| { | ||||||
| rm -rf "$project_name" | ||||||
| node "$CLI_PATH" init "$project_name" --template "$REPO_ROOT" | ||||||
| } | ||||||
| popd | ||||||
|
|
||||||
| info "Double checking the versions in package.json are correct:" | ||||||
| grep "\"react-native\": \".*react-native-$PACKAGE_VERSION.tgz\"" "${project_path}/package.json" || error "Incorrect version number in ${project_path}/package.json" | ||||||
| grep -E "com.facebook.react:react-native:\\+" "${project_path}/android/app/build.gradle" || error "Dependency in ${project_path}/android/app/build.gradle must be com.facebook.react:react-native:+" | ||||||
|
|
||||||
| success "New sample project generated at ${project_path}" | ||||||
|
|
||||||
| pushd "$project_path" | ||||||
| { | ||||||
| # Android | ||||||
| { | ||||||
| info "Deleting previously installed Android $project_name app" | ||||||
| adb uninstall com.$(echo $project_name | awk '{print tolower($0)}') | ||||||
|
|
||||||
| info "Test the following on Android:" | ||||||
| info " - Disable Fast Refresh. It might be enabled from last time (the setting is stored on the device)" | ||||||
| info " - Verify 'Reload JS' works" | ||||||
| info "" | ||||||
| info "Press any key to run the sample in Android emulator/device" | ||||||
| info "" | ||||||
| read -n 1 | ||||||
| node "$CLI_PATH" run-android | ||||||
| } | ||||||
|
|
||||||
| # iOS | ||||||
| { | ||||||
| info "Test the following on iOS:" | ||||||
| info " - Disable Fast Refresh. It might be enabled from last time (the setting is stored on the device)" | ||||||
| info " - Verify 'Reload JS' works" | ||||||
| info " - Test Chrome debugger by adding breakpoints and reloading JS. We don't have tests for Chrome debugging." | ||||||
| info " - Disable Chrome debugging." | ||||||
| info " - Enable Fast Refresh, change a file (index.js) and save. The UI should refresh." | ||||||
| info " - Disable Fast Refresh." | ||||||
| info "" | ||||||
| info "Press any key to open the project in Xcode" | ||||||
| info "" | ||||||
| read -n 1 | ||||||
| node "$CLI_PATH" run-ios | ||||||
| } | ||||||
| } | ||||||
| popd | ||||||
| } | ||||||
|
|
||||||
| info "Next steps:" | ||||||
|
Contributor
There was a problem hiding this comment. tbh I think that these last 2 lines could be even be removed, I don't think they provide any actual value. Or maybe we could change the link to point to https://github.com/react-native-community/releases/blob/master/README.md or even https://github.com/react-native-community/releases/blob/master/docs/release-process.md? |
||||||
| info " - https://github.com/facebook/react-native/blob/master/Releases.md" | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably change a bit this section to 'clean up the house' more. For ex. I'd extract (similar to what happens to
kill_packagers) all the cleanup part to its own method and in it, something along the lines of:and call it after
info "Preparing version $PACKAGE_VERSION"What do you think?
PS: maybe we could even add some more scripts to that like
rm -rf ~/Library/Developer/Xcode/DerivedData/*