Disable gflags include#28451
Closed
KDederichs wants to merge 3 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: 8e66f0b |
Base commit: 8e66f0b |
Contributor
|
@sota000 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
sota000
suggested changes
Sep 3, 2021
Contributor
sota000
left a comment
sota000
left a comment
There was a problem hiding this comment.
Hi @KDederichs, apologies for taking the time to review. Could you please address the comment I made inline and solve the merge conflict? Thank you for the contribution!
Contributor
Author
|
No worries, projects of this size get a lot of contribution so I understand that small stuff like this lies around for a while. |
Contributor
|
@sota000 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue explained in #28446
It basically disabled the gflags include before configure can detect the header on the users system.
Changelog
[iOS] [Fixed] - Fixed inability to build apps when gflags is installed
Test Plan
Tested by installing gflags
brew install gflagsand verifying that apps build after.