Skip to content

[CI] Loosen up restrictions for internal changelogs#28486

Closed
hramos wants to merge 2 commits into
facebook:masterfrom
hramos:internal-changelog
Closed

[CI] Loosen up restrictions for internal changelogs#28486
hramos wants to merge 2 commits into
facebook:masterfrom
hramos:internal-changelog

Conversation

@hramos
Copy link
Copy Markdown
Contributor

@hramos hramos commented Apr 1, 2020

Summary

Do not nag on PRs that contain internal changelogs (meaning, the change doesn't need to be called out in release notes).

Changelog

[Internal] - This should be acceptable.

Test Plan

See PR.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team labels Apr 1, 2020
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,605,544 -121
android hermes armeabi-v7a 6,282,661 -115
android hermes x86 6,946,324 -120
android hermes x86_64 6,876,563 -113
android jsc arm64-v8a 8,913,886 -56
android jsc armeabi-v7a 8,554,348 -35
android jsc x86 8,738,700 -52
android jsc x86_64 9,315,151 -66

Base commit: ec0c65c

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 2, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 956,000 -9,886,336

Base commit: 52b3105

@hramos hramos marked this pull request as ready for review April 2, 2020 16:28
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @hramos in 46f4109.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants