Skip to content

eslint-config: add version badge and add homepage for eslint-config#28506

Closed
Naturalclar wants to merge 1 commit into
facebook:masterfrom
Naturalclar:chore/updateEslintConfigREADME
Closed

eslint-config: add version badge and add homepage for eslint-config#28506
Naturalclar wants to merge 1 commit into
facebook:masterfrom
Naturalclar:chore/updateEslintConfigREADME

Conversation

@Naturalclar
Copy link
Copy Markdown
Contributor

@Naturalclar Naturalclar commented Apr 3, 2020

Summary

Add version badge to README of eslint-config, and add specific url for the homepage so people looking at the npm package can find out where the package is from.

Changelog

[Internal] [Changed] - Add version badge to README of eslint-config

Test Plan

Not required as the only changes are made in README and homepage prop of package.json

@Naturalclar Naturalclar requested a review from matt-oakes as a code owner April 3, 2020 09:33
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2020
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,607,449 0
android hermes armeabi-v7a 6,284,307 0
android hermes x86 6,948,198 0
android hermes x86_64 6,878,682 0
android jsc arm64-v8a 8,915,721 0
android jsc armeabi-v7a 8,555,924 0
android jsc x86 8,740,503 0
android jsc x86_64 9,317,240 0

Base commit: 3a11f05

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 3, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 10,843,936 9,878,384

Base commit: 3a11f05

@Naturalclar Naturalclar changed the title docs: add version badge and add homepage for eslint-config eslint-config: add version badge and add homepage for eslint-config Apr 3, 2020
Copy link
Copy Markdown
Contributor

@matt-oakes matt-oakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. I presume that NPM will only pick up the new homepage when a new version is published?

@cpojer Can you start the merge process for this?

Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @Naturalclar in 83fee73.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 3, 2020
@Naturalclar Naturalclar deleted the chore/updateEslintConfigREADME branch April 4, 2020 03:23
@Naturalclar
Copy link
Copy Markdown
Contributor Author

@matt-oakes

I presume that NPM will only pick up the new homepage when a new version is published?

Yes, npm page only updates when a new version is published.
not sure if it's worth publishing a new version with just this change, I'll leave that up to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants