Skip to content

Resolve RNTester Xcode warnings#28676

Closed
safaiyeh wants to merge 1 commit into
facebook:masterfrom
safaiyeh:RNTester-Xcode-warnings
Closed

Resolve RNTester Xcode warnings#28676
safaiyeh wants to merge 1 commit into
facebook:masterfrom
safaiyeh:RNTester-Xcode-warnings

Conversation

@safaiyeh
Copy link
Copy Markdown
Contributor

Summary

Resolve RNTester Xcode warnings.

Changelog

[Internal] [iOS] - Resolve RNTester Xcode warnings

Test Plan

Building RNTester no longer shows project setting warnings

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2020
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,759,422 0
android hermes armeabi-v7a 6,406,537 0
android hermes x86 7,140,904 0
android hermes x86_64 7,032,199 0
android jsc arm64-v8a 8,927,996 0
android jsc armeabi-v7a 8,567,471 0
android jsc x86 8,752,596 0
android jsc x86_64 9,329,505 0

Base commit: 0a67133

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 18, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 809,568 0

Base commit: 0a67133

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@shergin
Copy link
Copy Markdown
Contributor

shergin commented Apr 19, 2020

@safaiyeh It does not compile saying The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @safaiyeh in 6de9f37.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants