Skip to content

Move RuntimeExecutor to its own BUCK module#28730

Closed
ejanzer wants to merge 1 commit into
facebook:masterfrom
ejanzer:export-D21098528
Closed

Move RuntimeExecutor to its own BUCK module#28730
ejanzer wants to merge 1 commit into
facebook:masterfrom
ejanzer:export-D21098528

Conversation

@ejanzer
Copy link
Copy Markdown

@ejanzer ejanzer commented Apr 22, 2020

Summary:
Moving RuntimeExecutor out of react/utils and into its own subdir of ReactCommon. I'm doing this because I'm going to be pulling this into CatalystInstance on Android, and I don't want to pull in all the files we don't need there; also, this should hopefully make the OSS NDK stuff easier (this uses the react/utils prefix to export, and I'm not sure if you can include a '/' in a gradle module name?)

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D21098528

@facebook-github-bot facebook-github-bot added p: Facebook Partner: Facebook Partner RN Team CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Apr 22, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D21098528

@pull-bot
Copy link
Copy Markdown

pull-bot commented Apr 22, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against b4e14e3

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 22, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,743,521 0
android hermes armeabi-v7a 6,408,496 0
android hermes x86 7,125,429 0
android hermes x86_64 7,015,813 0
android jsc arm64-v8a 8,912,004 0
android jsc armeabi-v7a 8,569,365 0
android jsc x86 8,737,032 0
android jsc x86_64 9,313,046 0

Base commit: e68f9bf

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 22, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 809,568 -9,866,464

Base commit: e68f9bf

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D21098528

Summary:
Pull Request resolved: facebook#28730

Moving RuntimeExecutor out of react/utils and into its own subdir of ReactCommon. I'm doing this because I'm going to be pulling this into CatalystInstance on Android, and I don't want to pull in all the files we don't need there; also, this should hopefully make the OSS NDK stuff easier (this uses the react/utils prefix to export, and I'm not sure if you can include a '/' in a gradle module name?)

Changelog: [Internal]

Reviewed By: shergin, mdvacca

Differential Revision: D21098528

fbshipit-source-id: 3a17da9c7159d91425269dfdbe1baf9dac250d52
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D21098528

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @ejanzer in 79d5b20.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants