docs: mention prettier in eslint-config README#28930
Conversation
The combination of `eslint` (v7.0.0), `@react-native-community/eslint-config` (v1.1.0), and `flow-typed` (v3.1.0) causes an error where `ESLint couldn't find the plugin "eslint-plugin-prettier"` because `flow-typed` depends on `prettier: ^1.19.1` (c.f. https://github.com/flow-typed/flow-typed/blob/master/cli/package.json#L38)
|
Hi @exKAZUu! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: c8d678a |
Base commit: c8d678a |
|
Thanks for this. I think this makes sense. People should already be getting a warning about a missing peer dependency as the ‘eslint-plugin-prettier’ package has that defined. @cpojer Can you merge this in? |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @exKAZUu in 0a2bb71. When will my fix make it into a release? | Upcoming Releases |
Summary
The combination of
eslint(v7.0.0),@react-native-community/eslint-config(v1.1.0), andflow-typed(v3.1.0) causes the following error (ESLint couldn't find the plugin "eslint-plugin-prettier") becauseflow-typed(v3.1.0) depends onprettier: ^1.19.1(c.f. https://github.com/flow-typed/flow-typed/blob/master/cli/package.json#L38).To deal with the error, developers should install
prettier(v2.x) directly indevDependencies.Changelog
[Internal] [Changed] -
@react-native-community/eslint-configREADME recommends developers to install prettier directlyTest Plan
This PR changes only README, so tests are not required.