Fix imports in RCTUtilsUIOverride.h#28946
Closed
Fanghao wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: 43c161c |
Base commit: 43c161c |
Contributor
|
Wow, Bazel! Cool! |
facebook-github-bot
approved these changes
May 22, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @Fanghao in b7e8f66. When will my fix make it into a release? | Upcoming Releases |
jerrymarino
added a commit
to bazel-xcode/PodToBUILD
that referenced
this pull request
Jul 20, 2020
The current search logic didn't write the default prefix header which is required for some cocoapods. It follows the logic defined in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb:170 Additonally, this was discovered when updating to react native and there was a required fix for bazel here, which we won't need to keep up with facebook/react-native#28946
jerrymarino
added a commit
to bazel-xcode/PodToBUILD
that referenced
this pull request
Jul 20, 2020
The current search logic didn't write the default prefix header which is required for some cocoapods. It follows the logic defined in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb:170 Additonally, this was discovered when updating to react native and there was a required fix for bazel here, which we won't need to keep up with facebook/react-native#28946
jerrymarino
added a commit
to bazel-xcode/PodToBUILD
that referenced
this pull request
Jul 21, 2020
* Use cocoapods default prefix header The current search logic didn't write the default prefix header which is required for some cocoapods. It follows the logic defined in lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb:170 Additonally, this was discovered when updating to react native and there was a required fix for bazel here, which we won't need to keep up with facebook/react-native#28946 Additionally, it adds react native to the build tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While we build react native 0.62.2 via our Bazel build system, encountered those following errors due to lack of appropriate imports:
Add the appropriate imports
<Foundation/Foundation.h>and<UIKit/UIKit.h>fix those errors.Honestly I dont know how it's supposed to work without those imports. Also all the siblings files have the correct imports. e.g. RCTUtils.h
Changelog
[iOS] [Fixed] - Fix imports in
RCTUtilsUIOverride.hTest Plan
RN tester iOS app runs fine.