Skip to content

Split EventDispatcher into interface and impl#28983

Closed
ejanzer wants to merge 1 commit intofacebook:masterfrom
ejanzer:export-D21695401
Closed

Split EventDispatcher into interface and impl#28983
ejanzer wants to merge 1 commit intofacebook:masterfrom
ejanzer:export-D21695401

Conversation

@ejanzer
Copy link
Copy Markdown

@ejanzer ejanzer commented May 26, 2020

Summary:
Creating an interface for EventDispatcher so I can implement it from a dummy/no-op EventDispatcher to use in bridgeless mode when the instance isn't alive.

Changelog: [Android] [Changed] Renamed EventDispatcher to EventDispatcherImpl and created EventDispatcher interface; calls to EventDispatcher contstructor need to be updated

Reviewed By: makovkastar

Differential Revision: D21695401

Summary:
Creating an interface for EventDispatcher so I can implement it from a dummy/no-op EventDispatcher to use in bridgeless mode when the instance isn't alive.

Changelog: [Android] [Changed] Renamed EventDispatcher to EventDispatcherImpl and created EventDispatcher interface; calls to EventDispatcher contstructor need to be updated

Reviewed By: makovkastar

Differential Revision: D21695401

fbshipit-source-id: d84f05e936518b40a36197181caa950f1e386e6c
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team fb-exported labels May 26, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D21695401

@pull-bot
Copy link
Copy Markdown

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 8f573ab

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented May 26, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 809,568 0

Base commit: ae7df2d

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,780,718 96
android hermes armeabi-v7a 6,442,968 106
android hermes x86 7,165,834 77
android hermes x86_64 7,056,521 96
android jsc arm64-v8a 8,948,503 77
android jsc armeabi-v7a 8,603,150 111
android jsc x86 8,776,758 107
android jsc x86_64 9,353,043 82

Base commit: ae7df2d

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @ejanzer in 68c0edd.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants