fix StatusBar showHideTransition flow type issue#29034
Closed
Simek wants to merge 1 commit into
Closed
Conversation
Base commit: ceb6c3d |
Base commit: ceb6c3d |
Member
|
I'm not familiar with this code, can you include more context showing how |
Collaborator
Author
|
@TheSavior Code based on the website example, which I have used to validate the docs: |
Collaborator
Author
|
|
Collaborator
Author
|
@TheSavior Are you waiting for some more information or what's the issue here? |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @Simek in e5a8f42. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This small PR adds third, missing
StatusBarAnimationpossible value to theshowHideTransitionprop validation -'none'.This fixes the following issue when
<StatusBar showHideTransition="none" />code is used:Changelog
[iOS] [Fixed] - fix StatusBar showHideTransition flow type issue
Test Plan
I have run the
flowcheck in the test project which uses local working copy ofreact-nativewith this change included.