Skip to content

Fix static method in file header#29118

Closed
potlov wants to merge 1 commit intofacebook:masterfrom
potlov:fix-static-in-head-file
Closed

Fix static method in file header#29118
potlov wants to merge 1 commit intofacebook:masterfrom
potlov:fix-static-in-head-file

Conversation

@potlov
Copy link
Copy Markdown
Contributor

@potlov potlov commented Jun 11, 2020

Summary

I have looked into recent commits and found a typical mistake when static is used in .h file.
Here static is not necessary. See link: https://stackoverflow.com/questions/780730/c-c-static-function-in-header-file-what-does-it-mean

Changelog

[General] [Fixed] - Removed static key word

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2020
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,762,056 0
android hermes armeabi-v7a 6,424,974 0
android hermes x86 7,148,529 0
android hermes x86_64 7,038,440 0
android jsc arm64-v8a 8,935,482 0
android jsc armeabi-v7a 8,590,800 0
android jsc x86 8,765,109 0
android jsc x86_64 9,340,639 0

Base commit: 03443d7

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jun 11, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 10,785,264 9,955,824

Base commit: 03443d7

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @potlov in 208e4d2.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants