Skip to content

Add accessibilityHint to TouchableNativeFeedback#29154

Closed
CMDadabo wants to merge 1 commit into
facebook:masterfrom
CMDadabo:patch-1
Closed

Add accessibilityHint to TouchableNativeFeedback#29154
CMDadabo wants to merge 1 commit into
facebook:masterfrom
CMDadabo:patch-1

Conversation

@CMDadabo
Copy link
Copy Markdown
Contributor

Summary

The docs suggest that TouchableNativeFeedback inherits TouchableWithoutFeedback props but accessibilityHint was missing.

Changelog

[Android] [Added] - Add accessibilityHint to TouchableNativeFeedback

Test Plan

Not sure how this should be tested, but I'm happy to implement what others may suggest

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2020
@react-native-bot react-native-bot added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Jun 16, 2020
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jun 16, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 10,785,824 9,956,384

Base commit: 62aa84a

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,763,137 14
android hermes armeabi-v7a 6,425,929 15
android hermes x86 7,149,461 32
android hermes x86_64 7,039,403 42
android jsc arm64-v8a 8,936,508 3
android jsc armeabi-v7a 8,591,678 4
android jsc x86 8,765,952 18
android jsc x86_64 9,341,516 1

Base commit: 62aa84a

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @CMDadabo in 72285d8.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants