Adding Accessibility Display Options Enabled to RNTester#29231
Closed
graytmatterMS wants to merge 4 commits into
Closed
Adding Accessibility Display Options Enabled to RNTester#29231graytmatterMS wants to merge 4 commits into
graytmatterMS wants to merge 4 commits into
Conversation
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
Base commit: a50f736 |
Base commit: a50f736 |
lunaleaps
approved these changes
Jul 2, 2021
Contributor
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
lunaleaps
reviewed
Jul 6, 2021
| // Fabric Detection | ||
| // eslint-disable-next-line dot-notation | ||
| const isFabric = !!( | ||
| this._ref && this._ref['_internalInstanceHandle']?.stateNode?.canonical |
Contributor
There was a problem hiding this comment.
We'll have to revert this. As I've learned from @TheSavior our babel transform has issues with _ prefixed properties
lunaleaps
requested changes
Jul 6, 2021
Contributor
lunaleaps
left a comment
lunaleaps
left a comment
There was a problem hiding this comment.
@graytmatterMS I'm having trouble landing this due to the merge conflicts -- could you fix and push and I can try to land again?
Contributor
|
@lunaleaps merged this pull request in 2abacac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently there isn't any way to test if the Accessibility Display Options or the event listeners for them were working properly within RNTester. It turns out that because of changes to the accessibility API Apple made when they added Smart Invert AccessibilityInfo.isInvertColorsEnabled() and the associated event listener are working incorrectly. You can see this if you take a look at how RNTester (with this PR incorporated) responds to toggling Invert Colors. I've submitted a bug report to Apple, but this might have been caught earlier if this had been implemented.
Changelog
[General] [Added] - Adding Accessibility Display Options Enabled to RNTester
Test Plan