Skip to content

Setup the ShadowNode tree for RCTParagraphComponentViewTests#29470

Closed
ZHUANGPP wants to merge 1 commit into
facebook:masterfrom
ZHUANGPP:export-D22536626
Closed

Setup the ShadowNode tree for RCTParagraphComponentViewTests#29470
ZHUANGPP wants to merge 1 commit into
facebook:masterfrom
ZHUANGPP:export-D22536626

Conversation

@ZHUANGPP
Copy link
Copy Markdown
Contributor

Summary:
Changelog:
[Internal] - Build the framework of the RCTParagraphComponentViewTests and do some setup.

I built a shadowNode tree here for future tests.

Differential Revision: D22536626

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team fb-exported labels Jul 22, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D22536626

@pull-bot
Copy link
Copy Markdown

pull-bot commented Jul 22, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 5000cda

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Jul 22, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,764,838 0
android hermes armeabi-v7a 6,432,486 0
android hermes x86 7,152,672 0
android hermes x86_64 7,042,558 0
android jsc arm64-v8a 8,936,092 0
android jsc armeabi-v7a 8,596,134 0
android jsc x86 8,767,047 0
android jsc x86_64 9,342,567 0

Base commit: 63377fa

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D22536626

…k#29470)

Summary:
Pull Request resolved: facebook#29470

Changelog:
[Internal] - Build the framework of the RCTParagraphComponentViewTests and do some setup.

I built a shadowNode tree here for future tests.

Reviewed By: shergin

Differential Revision: D22536626

fbshipit-source-id: 689fe588b041b7f185e8c48c66fa127b44c9cae0
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D22536626

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 63377fa

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in c03a6ab.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants