chore: use es6 import for DrawerLayoutAndroid#29639
Closed
gedeagas wants to merge 2 commits into
Closed
Conversation
Base commit: 7fb1afa |
Base commit: 7fb1afa |
mdvacca
approved these changes
Aug 13, 2020
Contributor
mdvacca
left a comment
There was a problem hiding this comment.
LGTM, importing to review and land
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@mdvacca Hi, I see that some facebook internal checks were not successful. is that okay? |
Collaborator
|
This pull request was successfully merged by @gedeagas in d1f217e. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrating DrawerLayoutAndroid component to use ES6 import
Slowly migrate each file to use es6 import/exports to make this discussion happen
react-native-community/discussions-and-proposals#201 (comment)
Changelog
[General] [Changed] - Use ES6 import/export syntax for DrawerLayoutAndroid component
Test Plan
Manual RNTester for Android