Skip to content

chore: use es6 import for DrawerLayoutAndroid#29639

Closed
gedeagas wants to merge 2 commits into
facebook:masterfrom
gedeagas:chore/es6-drawerlayout-android
Closed

chore: use es6 import for DrawerLayoutAndroid#29639
gedeagas wants to merge 2 commits into
facebook:masterfrom
gedeagas:chore/es6-drawerlayout-android

Conversation

@gedeagas
Copy link
Copy Markdown
Contributor

@gedeagas gedeagas commented Aug 13, 2020

Summary

Migrating DrawerLayoutAndroid component to use ES6 import

Slowly migrate each file to use es6 import/exports to make this discussion happen
react-native-community/discussions-and-proposals#201 (comment)

Changelog

[General] [Changed] - Use ES6 import/export syntax for DrawerLayoutAndroid component

Test Plan

Manual RNTester for Android

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2020
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7fb1afa

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,842,036 838,890
android hermes armeabi-v7a 7,455,834 789,096
android hermes x86 8,300,541 877,076
android hermes x86_64 8,193,559 879,201
android jsc arm64-v8a 10,001,670 838,980
android jsc armeabi-v7a 9,607,606 789,192
android jsc x86 9,888,255 877,184
android jsc x86_64 10,467,476 879,300

Base commit: 7fb1afa

Copy link
Copy Markdown
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, importing to review and land

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@gedeagas
Copy link
Copy Markdown
Contributor Author

@mdvacca Hi, I see that some facebook internal checks were not successful. is that okay?

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @gedeagas in d1f217e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants