Skip to content

Removing unused import on RCTMultilineTextInputNativeComponent & RCTSingelineTextInputNativeComponent spec. #29652

Closed
gedeagas wants to merge 2 commits into
facebook:masterfrom
gedeagas:fix/unused-import
Closed

Removing unused import on RCTMultilineTextInputNativeComponent & RCTSingelineTextInputNativeComponent spec. #29652
gedeagas wants to merge 2 commits into
facebook:masterfrom
gedeagas:fix/unused-import

Conversation

@gedeagas
Copy link
Copy Markdown
Contributor

Summary

This pr removes unused import on RCTMultilineTextInputNativeComponent & RCTSingelineTextInputNativeComponent spec.

Changelog

[General] [Changed] - Removing unused import on RCTMultilineTextInputNativeComponent & RCTSingelineTextInputNativeComponent spec.

Test Plan

@todo

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,002,986 -44
android hermes armeabi-v7a 6,666,595 -48
android hermes x86 7,423,286 -69
android hermes x86_64 7,314,199 -48
android jsc arm64-v8a 9,162,761 -37
android jsc armeabi-v7a 8,818,490 -38
android jsc x86 9,011,158 -32
android jsc x86_64 9,588,254 -29

Base commit: 208ebed

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 208ebed

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2020
@gedeagas
Copy link
Copy Markdown
Contributor Author

cc @sammy-SC. because this is spec file for fabric i don't know how to test it. but should be working fine.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sammy-SC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@sammy-SC
Copy link
Copy Markdown
Contributor

@gedeagas thank you!
The change looks good.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @gedeagas in 8d198ee.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants