Skip to content

Fix RNTester Path #29786

Closed
chirag-singhal wants to merge 1 commit into
facebook:masterfrom
MLH-Fellowship:update_documentation
Closed

Fix RNTester Path #29786
chirag-singhal wants to merge 1 commit into
facebook:masterfrom
MLH-Fellowship:update_documentation

Conversation

@chirag-singhal
Copy link
Copy Markdown
Contributor

Summary

  • Corrects running on android instructions for rn-tester
  • Corrects path for rn-tester in package.json, contributing.md and .buckconfig

Changelog

[General] [Fixed] - Fix rn-tester path in documentation and configs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2020
@pull-bot
Copy link
Copy Markdown

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against d069a76

@chirag-singhal
Copy link
Copy Markdown
Contributor Author

@rickhanlonii some minor fixes for the documentation and buckconfig

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,211,428 0
android hermes armeabi-v7a 6,860,602 0
android hermes x86 7,646,060 0
android hermes x86_64 7,537,004 0
android jsc arm64-v8a 9,370,138 0
android jsc armeabi-v7a 9,011,442 0
android jsc x86 9,232,862 0
android jsc x86_64 9,810,016 0

Base commit: 0fb7f5a

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0fb7f5a

Copy link
Copy Markdown
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @chirag-singhal in abb6433.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants