Fix CircleCI breakage in RCTPropsAnimatedNode#29800
Closed
PeteTheHeat wants to merge 2 commits into
Closed
Conversation
added 2 commits
August 28, 2020 10:37
Differential Revision: D23146036 fbshipit-source-id: d407c11992ce739cae8cb1482aabadf407d920a2
Summary: I changed this line in D23272735 (facebook@700960c), to conform to normal ObjC semantics: impl files can import their header by file name. I forgot that their's some special linking logic happening in this directory that doesn't allow for this import type. This diff just reverts one line to fix CircleCI builds. Changelog: [Internal] Differential Revision: D23399893 fbshipit-source-id: 1071af66d9279304921dc10d167e04794ae93180
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23399893 |
|
Base commit: 6729a3e |
Base commit: 6729a3e |
Collaborator
|
This pull request was successfully merged by @PeteTheHeat in b231e3a. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I changed this line in D23272735 (700960c), to conform to normal ObjC semantics: impl files can import their header by file name.
I forgot that their's some special linking logic happening in this directory that doesn't allow for this import type.
This diff just reverts one line to fix CircleCI builds.
Changelog: [Internal]
Differential Revision: D23399893