New Toast Android Component Use Cases#29850
Closed
chirag-singhal wants to merge 2 commits into
Closed
Conversation
Base commit: 5acf7c9 |
Base commit: 5acf7c9 |
0ec3cb9 to
67cce47
Compare
67cce47 to
9ff4da1
Compare
rickhanlonii
reviewed
Sep 9, 2020
Member
rickhanlonii
left a comment
There was a problem hiding this comment.
Code looks good, can you include a before/after demo in the test plan?
Contributor
Author
|
Updated the test plan! |
Member
|
@chirag-singhal the new pressable items say "click me" instead of "tap me", shouldn't they say "tap"? |
Contributor
Author
|
@rickhanlonii the new version says tap to view toast, the older version had text 'click me' |
Member
|
Oh I see, thanks! |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @chirag-singhal in 6ee1467. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changelog
[General] [Changed] - Changed use cases for toast android component in rn-tester
Test Plan
After -
Before -