Skip to content

New Toast Android Component Use Cases#29850

Closed
chirag-singhal wants to merge 2 commits into
facebook:masterfrom
MLH-Fellowship:use-cases/toast
Closed

New Toast Android Component Use Cases#29850
chirag-singhal wants to merge 2 commits into
facebook:masterfrom
MLH-Fellowship:use-cases/toast

Conversation

@chirag-singhal
Copy link
Copy Markdown
Contributor

@chirag-singhal chirag-singhal commented Sep 3, 2020

Summary

  • New use cases for toast android component in rn-tester

Changelog

[General] [Changed] - Changed use cases for toast android component in rn-tester

Test Plan

  • Tested app in both Android and iOS
    After -
    image
    Before -
    image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2020
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Sep 3, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5acf7c9

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Sep 3, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,209,181 -276
android hermes armeabi-v7a 6,858,357 -264
android hermes x86 7,643,813 -272
android hermes x86_64 7,534,765 -272
android jsc arm64-v8a 9,369,134 76
android jsc armeabi-v7a 9,010,438 76
android jsc x86 9,231,858 84
android jsc x86_64 9,809,002 76

Base commit: 5acf7c9

Copy link
Copy Markdown
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, can you include a before/after demo in the test plan?

@chirag-singhal
Copy link
Copy Markdown
Contributor Author

Updated the test plan!

@rickhanlonii
Copy link
Copy Markdown
Member

@chirag-singhal the new pressable items say "click me" instead of "tap me", shouldn't they say "tap"?

@chirag-singhal
Copy link
Copy Markdown
Contributor Author

@rickhanlonii the new version says tap to view toast, the older version had text 'click me'

@rickhanlonii
Copy link
Copy Markdown
Member

Oh I see, thanks!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @chirag-singhal in 6ee1467.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants