Update Alert API Examples in RNTester#29855
Conversation
facebook-github-bot
added
the
CLA Signed
|
@rickhanlonii I have created the PR for the Alert Screen. Please take a look :) |
|
Base commit: d6fef50 |
Base commit: d6fef50 |
rickhanlonii
left a comment
rickhanlonii
left a comment
There was a problem hiding this comment.
Looks good, can you include a screenshot or demo in the test plan?
| * @format | ||
| */ | ||
|
|
||
| /* global device, element, by, expect, waitFor */ |
There was a problem hiding this comment.
This shouldn't be necessary because they're configured in the eslint/flow settings. Is that not working?
There was a problem hiding this comment.
No, it is not working.
There was a problem hiding this comment.
element may not be configured but device and expect should be?
| await element(by.label('Back')).tap(); | ||
| }); | ||
|
|
||
| it('should show alert dialog with message and default button', async () => { |
There was a problem hiding this comment.
Ideally these test descriptions would specify which example they're testing.
There was a problem hiding this comment.
I am not sure how I should add them. I have pushed one commit. Please let me know if that's the correct way to do it.
|
@rickhanlonii Thanks for the review! I have added the screen-recording in the PR description. Please let me know if you need anything else. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @anku255 in 1b943a9. When will my fix make it into a release? | Upcoming Releases |
6 participants
Summary
This PR updates the Alert API Examples in RNTester. It is part of the MLH Fellowship.
Changelog
Test Plan
Screen Recording: https://i.imgur.com/9ubMmDC.mp4
Alertsand tap on it