New Keyboard Avoiding Component Use Cases#29857
Closed
chirag-singhal wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: 5acf7c9 |
Base commit: 5acf7c9 |
beatrizmf
approved these changes
Sep 3, 2020
chirag-singhal
force-pushed
the
use-cases/keyboard
branch
from
1e102f4 to
cfa73c9
Compare
rickhanlonii
reviewed
Sep 9, 2020
Member
rickhanlonii
left a comment
rickhanlonii
left a comment
There was a problem hiding this comment.
Code looks good, can you include a before/after demo in the test plan?
Contributor
Author
|
Updated the test plan! |
Member
|
Should the "open example" buttons be buttons? What did this look like before the UI redesign? |
Contributor
Author
|
Before UI redesign it used |
Member
|
Is there touch feedback when you tap? From the screenshots they don't look tappable? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @chirag-singhal in f11b1da. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changelog
[General] [Changed] - Changed use cases for keyboard avoiding component in rn-tester
Test Plan
After -
Before -