Skip to content

Fabric: Explicitly include algorithm in Rect.h#29884

Closed
empyrical wants to merge 1 commit into
facebook:masterfrom
empyrical:graphics-rect-include-algorithm
Closed

Fabric: Explicitly include algorithm in Rect.h#29884
empyrical wants to merge 1 commit into
facebook:masterfrom
empyrical:graphics-rect-include-algorithm

Conversation

@empyrical
Copy link
Copy Markdown
Contributor

Summary

This pull request adds an include statement including the header <algorithm> to react/renderer/graphics/Rect.h.

It is needed for building with MSVC because of the use of the std::max function. It seems that this header is included as a side effect of some other header that's being used when building with Clang, and for some reason it is not included when being built with MSVC.

Changelog

[Internal] [Added] - Fabric: Explicitly include algorithm in Rect.h

Test Plan

Files that include this header now successfully compile on MSVC.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Sep 8, 2020
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Sep 8, 2020
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4d920fe

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,209,453 0
android hermes armeabi-v7a 6,858,625 0
android hermes x86 7,644,089 0
android hermes x86_64 7,535,033 0
android jsc arm64-v8a 9,369,050 0
android jsc armeabi-v7a 9,010,350 0
android jsc x86 9,231,770 0
android jsc x86_64 9,808,922 0

Base commit: 4d920fe

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @empyrical in 0693d08.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants