Fabric Tests: Change default constructor in TestComponents' TestProps#29898
Closed
empyrical wants to merge 1 commit into
Closed
Fabric Tests: Change default constructor in TestComponents' TestProps#29898empyrical wants to merge 1 commit into
empyrical wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Base commit: 7e89934 |
Base commit: 7e89934 |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @empyrical in 777bf65. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request changes the default constructor in the
TestPropsclass inreact/renderer/core/tests/TestComponent.husing ViewProps::ViewProps;was causing problems in Visual Studio 2017 - changing it toTestProps() = default;allowed dependent CPP files to compile on MSVC and caused no regressions in the Fabric test suite.Changelog
[Internal] [Changed] - Fabric Tests: Change default constructor in TestComponents' TestProps
Test Plan
The Fabric test suite passes on Windows after this change is made. I also tested it under macOS and Linux built with Clang and they both pass with this change made.