Flow: fix VirtualizedList issues, remove few no longer valid suppressions

[Simek]

Summary

This PR fixes few suppressed Flow issues in VirtualizedList component.

I have also removed few no longer valid Flow suppressions in ActivityIndicator and ReactNativeTestTools.

Changelog

[General] [Fixed] - Flow: fix few issues in VirtualizedList,
[General] [Removed] - Flow: remove few no longer valid suppressions in ReactNativeTestTools

Test Plan

Successful run of yarn flow check.

[Simek]

I had to revert the ActivityIndicator suppression because Flow check fails on the CI (but work locally).

@cpojer This might be something to check out and verify. Is it possible that CI uses different version of Flow?

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 0d02c60

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,385,801	0
android	hermes	armeabi-v7a	7,013,117	0
android	hermes	x86	7,828,013	0
android	hermes	x86_64	7,717,499	0
android	jsc	arm64-v8a	9,532,102	0
android	jsc	armeabi-v7a	9,151,226	0
android	jsc	x86	9,396,778	0
android	jsc	x86_64	9,978,488	0

Base commit: 0d02c60

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[lunaleaps]

There are still flow errors when I imported this -- to fix, please change this to:

 (node.instance != null &&
        // $FlowFixMe[prop-missing] // Remove this after deleting `Touchable`
     typeof node.instance.touchableHandlePress === 'function'),

[lunaleaps]

and this to

node => node.props != null && regex.exec(node.props.children) !== null,

[Simek]

@lunaleaps Thank you for the review, I have applied the suggested changes.

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@lunaleaps merged this pull request in 927573c.