Skip to content

Remove filter pills from example page#30198

Closed
suminkimm wants to merge 2 commits into
facebook:masterfrom
MLH-Fellowship:remove-filter-pills
Closed

Remove filter pills from example page#30198
suminkimm wants to merge 2 commits into
facebook:masterfrom
MLH-Fellowship:remove-filter-pills

Conversation

@suminkimm
Copy link
Copy Markdown
Contributor

@suminkimm suminkimm commented Oct 16, 2020

Summary

@rickhanlonii
Removes filter pills from example page in RNTester app.

Changelog

Removed filter pills from example page by changing hideFilterPills property to true in RNTesterExampleList.js

[Android] [Removed] - Remove filter pills
[iOS] [Removed] - Remove filter pills

Test Plan

RNTester app builds and runs as expected and filter pills are removed from the screen.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @suminkimm!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,385,801 -4,096
android hermes armeabi-v7a 7,013,117 -4,096
android hermes x86 7,828,013 -4,096
android hermes x86_64 7,717,499 -4,096
android jsc arm64-v8a 9,532,102 -4,096
android jsc armeabi-v7a 9,151,226 0
android jsc x86 9,396,778 -4,096
android jsc x86_64 9,978,488 -4,096

Base commit: 213b02b

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Oct 16, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 36b0f7d

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@princiya
Copy link
Copy Markdown

@suminkimm all checks have passed 🎉

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@rickhanlonii
Copy link
Copy Markdown
Member

@suminkimm could you rebase this on top of master, it looks like there's a merge conflict. Sorry about that!

@mkcode mkcode force-pushed the remove-filter-pills branch from a3bd3bb to e4dbd29 Compare October 23, 2020 17:01
@mkcode
Copy link
Copy Markdown
Contributor

mkcode commented Oct 23, 2020

@rickhanlonii - Now rebased

@mkcode mkcode force-pushed the remove-filter-pills branch from e4dbd29 to 9a13aa1 Compare October 23, 2020 19:47
@rickhanlonii
Copy link
Copy Markdown
Member

Hm, now all of the tests are failing?

@suminkimm suminkimm force-pushed the remove-filter-pills branch 2 times, most recently from d8961af to 16ef240 Compare October 27, 2020 23:34
@suminkimm suminkimm force-pushed the remove-filter-pills branch from f958ef0 to 1451ebe Compare October 27, 2020 23:49
Co-authored-by: Su Min Kim <kims622@gmail.com>
Co-authored-by: Justin So <sojustin28@gmail.com>
@suminkimm suminkimm force-pushed the remove-filter-pills branch from 1451ebe to b56d0e5 Compare October 27, 2020 23:53
@mkcode
Copy link
Copy Markdown
Contributor

mkcode commented Oct 28, 2020

This rebase was done correctly, but Parent commit 1903f66 is still failing, as is current master @ 07d090d. We will need to put this down for now, and wait until we have a good base commit to rebase onto.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @suminkimm in 5cf4ab8.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Type: Removal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants