Remove filter pills from example page#30198
Conversation
|
Hi @suminkimm! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 213b02b |
Base commit: 36b0f7d |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@suminkimm all checks have passed 🎉 |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@suminkimm could you rebase this on top of master, it looks like there's a merge conflict. Sorry about that! |
a3bd3bb to
e4dbd29
Compare
|
@rickhanlonii - Now rebased |
e4dbd29 to
9a13aa1
Compare
|
Hm, now all of the tests are failing? |
d8961af to
16ef240
Compare
f958ef0 to
1451ebe
Compare
Co-authored-by: Su Min Kim <kims622@gmail.com> Co-authored-by: Justin So <sojustin28@gmail.com>
1451ebe to
b56d0e5
Compare
|
This pull request was successfully merged by @suminkimm in 5cf4ab8. When will my fix make it into a release? | Upcoming Releases |
Summary
@rickhanlonii
Removes filter pills from example page in RNTester app.
Changelog
Removed filter pills from example page by changing hideFilterPills property to true in RNTesterExampleList.js
[Android] [Removed] - Remove filter pills
[iOS] [Removed] - Remove filter pills
Test Plan
RNTester app builds and runs as expected and filter pills are removed from the screen.