Skip to content

Fix typo#30330

Closed
inokawa wants to merge 1 commit into
facebook:masterfrom
inokawa:fix-typo
Closed

Fix typo#30330
inokawa wants to merge 1 commit into
facebook:masterfrom
inokawa:fix-typo

Conversation

@inokawa
Copy link
Copy Markdown
Contributor

@inokawa inokawa commented Nov 7, 2020

Summary

Fix typo in comment

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2020
@pull-bot
Copy link
Copy Markdown

pull-bot commented Nov 7, 2020

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 58ce136

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 017bc91

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,507,811 +0
android hermes armeabi-v7a 7,099,323 +0
android hermes x86 7,945,738 +0
android hermes x86_64 7,856,777 +0
android jsc arm64-v8a 8,972,427 +0
android jsc armeabi-v7a 8,547,052 +0
android jsc x86 8,971,859 +0
android jsc x86_64 9,523,158 +0

Base commit: 017bc91

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @inokawa in cf97c1f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 18, 2020
@inokawa inokawa deleted the fix-typo branch November 18, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants