Skip to content

remove ReactFragmentActivity#30331

Closed
dulmandakh wants to merge 2 commits into
facebook:masterfrom
dulmandakh:remove-reactfragmentactivity
Closed

remove ReactFragmentActivity#30331
dulmandakh wants to merge 2 commits into
facebook:masterfrom
dulmandakh:remove-reactfragmentactivity

Conversation

@dulmandakh
Copy link
Copy Markdown
Contributor

Summary

Remove ReactFragmentActivity class, which was deprecated at least since 0.58.

Changelog

[Android] [Changed] - remove ReactFragmentActivity class.

Test Plan

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Nov 7, 2020
@react-native-bot react-native-bot added the Platform: Android Android applications. label Nov 7, 2020
@dulmandakh dulmandakh requested a review from hramos November 7, 2020 12:18
@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 017bc91

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,507,811 +0
android hermes armeabi-v7a 7,099,323 +0
android hermes x86 7,945,738 +0
android hermes x86_64 7,856,777 +0
android jsc arm64-v8a 8,972,427 +0
android jsc armeabi-v7a 8,547,052 +0
android jsc x86 8,971,859 +0
android jsc x86_64 9,523,158 +0

Base commit: 017bc91

@dulmandakh dulmandakh requested a review from fkgozali November 9, 2020 12:51
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@fkgozali
Copy link
Copy Markdown
Contributor

Actually, I just checked, we're still using this internally for other reasons. We could move it to just internal technically, but let's revisit a bit later?

@fkgozali
Copy link
Copy Markdown
Contributor

Actually, I just checked, we're still using this internally for other reasons. We could move it to just internal technically, but let's revisit a bit later?

Nevermind, the removed file was just an empty abstract subclass of ReactActivity, so I updated our internal callsites.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @dulmandakh in 2798e71.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants