Skip to content

enable hermes by default#30340

Closed
dulmandakh wants to merge 1 commit intofacebook:mainfrom
dulmandakh:hermes-default
Closed

enable hermes by default#30340
dulmandakh wants to merge 1 commit intofacebook:mainfrom
dulmandakh:hermes-default

Conversation

@dulmandakh
Copy link
Copy Markdown
Contributor

@dulmandakh dulmandakh commented Nov 8, 2020 •
edited
Loading

Summary

Hermes landed Proxy and supports most ES6 features, and IIRC, we talked and agreed to enable Hermes by default.

Changelog

[Android] [Changed] - enable Hermes by default

Test Plan

New projects will default to Hermes.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Nov 8, 2020
@react-native-bot react-native-bot added the Platform: Android Android applications. label Nov 8, 2020
@dulmandakh dulmandakh requested a review from cpojer November 8, 2020 02:24
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 8, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 017bc91

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 8, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,507,811 +0
android hermes armeabi-v7a 7,099,323 +0
android hermes x86 7,945,738 +0
android hermes x86_64 7,856,777 +0
android jsc arm64-v8a 8,972,427 +0
android jsc armeabi-v7a 8,547,052 +0
android jsc x86 8,971,859 +0
android jsc x86_64 9,523,158 +0

Base commit: 017bc91

@dulmandakh dulmandakh requested a review from fkgozali November 9, 2020 12:50
@cortinico
Copy link
Copy Markdown
Contributor

cortinico commented Apr 28, 2023

Closing as this has been implemented already

@cortinico cortinico closed this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpojer cpojer Awaiting requested review from cpojer

@fkgozali fkgozali Awaiting requested review from fkgozali

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Platform: Android Android applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dulmandakh @analysis-bot @cortinico @sota000 @facebook-github-bot @react-native-bot