stacktrace-parser: move require further up in the file#30345
Closed
pvinis wants to merge 1 commit intofacebook:mainfrom
Closed
stacktrace-parser: move require further up in the file#30345pvinis wants to merge 1 commit intofacebook:mainfrom
require further up in the file#30345pvinis wants to merge 1 commit intofacebook:mainfrom
Conversation
require further up in the file
Base commit: b6362c2 |
Base commit: b6362c2 |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running jest tests on 0.63.3, for some reason we kept getting the following error on CircleCI:
This
TypeError: stacktraceParser.parse is not a functionkept appearing at random tests.After we moved the
requirehigher up in the file, it never appeared again.Changelog
[Internal] [Fixed] - stacktrack-parser import fix
Test Plan