Added missing examples for TouchableHighlight and TouchableWithoutFeedback#30364
Closed
kshitij86 wants to merge 1 commit into
Closed
Added missing examples for TouchableHighlight and TouchableWithoutFeedback#30364kshitij86 wants to merge 1 commit into
kshitij86 wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
the
Type: Enhancement
Base commit: 9c827f6 |
kshitij86
changed the title
kshitij86
changed the title
Contributor
|
Looks great to me |
Base commit: 408bcde |
kshitij86
changed the title
Contributor
|
@kshitij86 - This looks good, but has lots of extra commits. Let's rebase this. |
kshitij86
force-pushed
the
add-examples-touchable-highlight
branch
from
1291658 to
ca202b6
Compare
Contributor
Author
|
@mkcode Done, squashed all those commits into a single one. |
Contributor
Author
|
@rickhanlonii Can you please take a look at these changes? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@rickhanlonii merged this pull request in b64ffd7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation - Missing examples for these props in the RNTester app
Changelog
[General] [Added] - Added example to ToucableHighlight
Test Plan