Skip to content

Add accessibility examples#30379

Closed
suminkimm wants to merge 4 commits into
facebook:masterfrom
MLH-Fellowship:add-accessibility-example
Closed

Add accessibility examples#30379
suminkimm wants to merge 4 commits into
facebook:masterfrom
MLH-Fellowship:add-accessibility-example

Conversation

@suminkimm
Copy link
Copy Markdown
Contributor

Summary

Added examples to RNTester for the AccessibilityInfo API for:

  1. SetAccessibilityFocus()
  2. isReduceMotionEnabled()
  3. iOS Only
    a. isBoldTextEnabled()
    b. isGrayScaleEnabled()
    c. isInvertColorsEnabled()
    d. isReduceTransparencyEnabled()

Changelog

[General] [Added] - Add new examples to the Accessibility API page

Test Plan

iOS GIF

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2020
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Nov 12, 2020
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 12, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 68a4761

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 12, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,526,829 +1,201
android hermes armeabi-v7a 7,112,069 +1,198
android hermes x86 7,967,290 +1,198
android hermes x86_64 7,878,594 +1,206
android jsc arm64-v8a 8,989,882 +0
android jsc armeabi-v7a 8,558,234 +0
android jsc x86 8,991,847 +0
android jsc x86_64 9,543,400 +0

Base commit: 68a4761

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add trailing comma

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flex:1
flex:1,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Platform
Platform,

@mkcode
Copy link
Copy Markdown
Contributor

mkcode commented Nov 13, 2020

This looks good to me.

@suminkimm suminkimm force-pushed the add-accessibility-example branch from 914cd93 to c059b97 Compare November 16, 2020 22:46
@suminkimm
Copy link
Copy Markdown
Contributor Author

@rickhanlonii the only test failing is test_ios_unit_frameworks_hermes which is also failing on master!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @suminkimm in 84dde67.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 8, 2020
@rickhanlonii rickhanlonii deleted the add-accessibility-example branch December 15, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants