Skip to content

Add keyboard avoiding view examples#30380

Closed
suminkimm wants to merge 7 commits into
facebook:masterfrom
MLH-Fellowship:add-keyboard-avoiding-view-example
Closed

Add keyboard avoiding view examples#30380
suminkimm wants to merge 7 commits into
facebook:masterfrom
MLH-Fellowship:add-keyboard-avoiding-view-example

Conversation

@suminkimm
Copy link
Copy Markdown
Contributor

Summary

Added examples to keyboard avoiding view in RNTester for:

  1. contentContainerStyle
  2. enabled

Changelog

[General] [Added] - Add keyboard avoiding view examples

Test Plan

Example

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2020
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Nov 12, 2020
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 12, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 68a4761

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Nov 12, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,508,419 -17,209
android hermes armeabi-v7a 7,099,922 -10,949
android hermes x86 7,946,346 -19,746
android hermes x86_64 7,857,379 -20,009
android jsc arm64-v8a 8,972,427 -17,455
android jsc armeabi-v7a 8,547,052 -11,182
android jsc x86 8,971,859 -19,988
android jsc x86_64 9,523,158 -20,242

Base commit: 68a4761

@suminkimm
Copy link
Copy Markdown
Contributor Author

@rickhanlonii The only failing test is test_ios_unit_frameworks_hermes which was failing on master!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

};

const KeyboardAvoidingContentContainerStyle = () => {
const [modalOpen, setModdalOpen] = useState(false);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we fix the spelling of "Modal"?

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@rickhanlonii merged this pull request in a724c8d.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 8, 2021
@rickhanlonii rickhanlonii deleted the add-keyboard-avoiding-view-example branch January 8, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants