Move TurboModuleManager to use RuntimeExecutor instead of jsContext#30416
Closed
ejanzer wants to merge 1 commit into
Closed
Move TurboModuleManager to use RuntimeExecutor instead of jsContext#30416ejanzer wants to merge 1 commit into
ejanzer wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21338930 |
|
Base commit: 00e623d |
ejanzer
force-pushed
the
export-D21338930
branch
from
fc4b33e to
c03f7fc
Compare
ejanzer
force-pushed
the
export-D21338930
branch
from
c03f7fc to
8889bbe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21338930 |
ejanzer
force-pushed
the
export-D21338930
branch
from
8889bbe to
33ec142
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21338930 |
ejanzer
force-pushed
the
export-D21338930
branch
from
33ec142 to
e377c77
Compare
…acebook#30416) Summary: Pull Request resolved: facebook#30416 This diff changes the constructor param for TurboModuleManager from jsContext (a long representing the `jsi::Runtime` pointer) to a RuntimeExecutor. It also updates callsites to use the new RuntimeExecutor created by CatalystInstance. This is only used for installing the TurboModule JSI binding; it's not currently used for JS invocation in TurboModules, which is handled separately by JSCallInvoker. Ultimately we may be able to implement JSCallInvoker *with* the provided RuntimeExecutor, but there's some additional logic in JSCallInvoker that we don't have here yet. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D21338930 fbshipit-source-id: 76074326a55d85fcf0f79125b2e7043203231dfd
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21338930 |
ejanzer
force-pushed
the
export-D21338930
branch
from
e377c77 to
8cbc89a
Compare
Base commit: 00e623d |
Collaborator
|
This pull request was successfully merged by @ejanzer in c0a2998. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff changes the constructor param for TurboModuleManager from jsContext (a long representing the
jsi::Runtimepointer) to a RuntimeExecutor. It also updates callsites to use the new RuntimeExecutor created by CatalystInstance. This is only used for installing the TurboModule JSI binding; it's not currently used for JS invocation in TurboModules, which is handled separately by JSCallInvoker. Ultimately we may be able to implement JSCallInvoker with the provided RuntimeExecutor, but there's some additional logic in JSCallInvoker that we don't have here yet.Changelog: [Internal]
Reviewed By: RSNara
Differential Revision: D21338930