Skip to content

Add remaining prop examples for the Image component#30554

Closed
JosephSemrai wants to merge 4 commits into
facebook:masterfrom
MLH-Fellowship:image-prop-examples
Closed

Add remaining prop examples for the Image component#30554
JosephSemrai wants to merge 4 commits into
facebook:masterfrom
MLH-Fellowship:image-prop-examples

Conversation

@JosephSemrai
Copy link
Copy Markdown
Contributor

@JosephSemrai JosephSemrai commented Dec 8, 2020

Summary

Adds missing prop examples for the Image component in rn-tester.

Changelog

[Internal] [Added] New examples for LoadingIndicatorSource, Accessibility, AccessibilityLabel, fadeDuration, onLayout, onPartialLoad, accessibilityLabel, etc.

Test Plan

  • Build rn-tester and verify that it runs
  • Interact with each component
  • Verify that the examples function as intended

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @JosephSemrai!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mkcode
Copy link
Copy Markdown
Contributor

mkcode commented Dec 8, 2020

Hi @JosephSemrai - Let's fix the flow errors in the analyze code step next.

Comment thread packages/rn-tester/js/examples/Image/ImageExample.js Outdated
Comment thread packages/rn-tester/js/examples/Image/ImageExample.js
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@rickhanlonii merged this pull request in 2aeb654.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 8, 2021
@rickhanlonii rickhanlonii deleted the image-prop-examples branch January 8, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants