Add Vibration module mock#30643
Closed
hduprat wants to merge 1 commit into
Closed
Conversation
Base commit: a0a45dc |
dulmandakh
approved these changes
Jan 5, 2021
Contributor
|
@hduprat could you please rebase so that CI are fixed |
770c8d3 to
a60f504
Compare
Base commit: a0a45dc |
Contributor
Author
@dulmandakh I did rebase but I still have one failing test. I currently don't know why |
a60f504 to
be92ce5
Compare
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @hduprat in 79529a1. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I wrote a test for a vibration feature in a react native app by importing the
Vibrationmodule and usingjest.spyOn(Vibration, 'vibrate').I had the following error:
That lead me to look for (and not find) a mock for the
Vibrationmodule in the code.Changelog
[General] [Fixed] - Add Jest mock for Vibration module
Test Plan
I would be glad to provide a test plan for this, but as it is part of testing I don't really know how to do so.
Any suggestion or help is welcome!