fix attempting to focus disabled textinputs

[vonovak]

Summary

when we call focus() upon a TextInput ref which has prop editable=false it marks the textinput as focused in TextInputState even though the focus is rejected by textinput itself because it is not editable.

then, when you change editable prop to true and call focus again, this condition or rather this one will evaluate to false and focus will not happen even though it can and should happen.

see also https://github.com/facebook/react-native/blob/0.64-stable/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js#L3895

Changelog

[General] [Fixed] - focus() on TextInput to respect its editable state

Test Plan

Create a TextInput with prop editable=false and call ref.current.focus() upon its ref. TextInput should not be marked as focused in TextInputState.

[vonovak]

this links to https://github.com/facebook/react-native/blob/0.64-stable/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js#L3895

without using Object.getPrototypeOf, we'd end up in a recursive call

[lunaleaps]

@yungsters had some feedback:
I think a better fix would be for the platform to return a boolean — true if the focus is successful, and false otherwise.

But for now, this logic should live in TextInputState.focusTextInput.

function focusTextInput(textField: ?ComponentRef) {
  // …

  if (currentlyFocusedInputRef !== textField && textField != null) {
    // EXPLANATION…
    if (textField.props?.editable === false) {
      return;
    }

    // …
  }
}

[vonovak]

@lunaleaps @yungsters the PR was updated, thanks for review

[aTreey]

thanks

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 2fdbf6a
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,188,178	-16,868
android	hermes	armeabi-v7a	7,788,310	-24,930
android	hermes	x86	8,558,123	-18,666
android	hermes	x86_64	8,511,165	-16,057
android	jsc	arm64-v8a	9,857,502	-16,356
android	jsc	armeabi-v7a	8,842,165	-24,421
android	jsc	x86	9,823,547	-18,136
android	jsc	x86_64	10,420,724	-15,518

Base commit: 2fdbf6a
Branch: main

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[lunaleaps]

@yungsters had some feedback:
I think a better fix would be for the platform to return a boolean — true if the focus is successful, and false otherwise.

But for now, this logic should live in TextInputState.focusTextInput.

function focusTextInput(textField: ?ComponentRef) {
  // …

  if (currentlyFocusedInputRef !== textField && textField != null) {
    // EXPLANATION…
    if (textField.props?.editable === false) {
      return;
    }

    // …
  }
}

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @vonovak in 8a5460c.

^{When will my fix make it into a release? | Upcoming Releases}