Minor code tweaks to work around a compiler bug in MSVC.#30696
Closed
acoates-ms wants to merge 1 commit into
Closed
Minor code tweaks to work around a compiler bug in MSVC.#30696acoates-ms wants to merge 1 commit into
acoates-ms wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Base commit: d3a3ce8 |
Base commit: d3a3ce8 |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@appden has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While pulling in additional react-native code into react-native-windows to support fabric, I hit some bugs with the MSVC compiler. These minor changes work around those bugs and shouldn't have any functional effect on the code
Changelog
[Internal] [Fixed] - Minor code tweaks to work around a compiler bug in MSVC.
Test Plan
Code compiles in MSVC and clang.